Skip to content

Fixes for resource reference resolution templates#413

Closed
jljaco wants to merge 1 commit intoaws-controllers-k8s:mainfrom
jljaco:fix-reference-resolution-templates
Closed

Fixes for resource reference resolution templates#413
jljaco wants to merge 1 commit intoaws-controllers-k8s:mainfrom
jljaco:fix-reference-resolution-templates

Conversation

@jljaco
Copy link
Contributor

@jljaco jljaco commented Feb 9, 2023

Fix for code originally in: #401

Description of changes:
There were some syntax errors in generated controller code for resource reference resolution. See here for some examples of compilation errors

Fixes here:

  • correct use of double-quotes in error messages

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link

ack-prow bot commented Feb 9, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2023
@ack-prow
Copy link

ack-prow bot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jljaco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested review from a-hilaly and vijtrip2 February 9, 2023 21:42
@ack-prow ack-prow bot added the approved label Feb 9, 2023
@jljaco jljaco marked this pull request as ready for review February 9, 2023 21:46
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2023
@jljaco jljaco requested a review from RedbackThomson February 9, 2023 21:46
@ack-prow
Copy link

ack-prow bot commented Feb 9, 2023

@jljaco: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-test 18e730e link true /test unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RedbackThomson
Copy link
Contributor

RedbackThomson commented Feb 9, 2023

Yeah this was a good lesson about using %q in generated code. Thanks

@jljaco
Copy link
Contributor Author

jljaco commented Feb 9, 2023

/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2023
@jljaco
Copy link
Contributor Author

jljaco commented Feb 9, 2023

We decided to revert #401 and #412 instead of fixing issues; closing this one but the fix here should be incorporated into the future un-revert PR

@jljaco jljaco closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

@RedbackThomson RedbackThomson Awaiting requested review from RedbackThomson

Assignees

No one assigned

Labels

approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jljaco @RedbackThomson